search

nephila / djangocms-page-sitemap

django CMS page extension to handle sitemap customization
BSD 3-Clause "New" or "Revised" License
9 stars 20 forks source link

'CMSToolbar' object has no attribute 'edit_mode' #30

Closed marcosguedes closed 5 years ago

marcosguedes commented 5 years ago

Hi everyone at Nephila . Thank you for this wonderful package.

It throws this error on Django CMS 3.6. You might already know what's going on. There's a similar request on other package that might help: https://github.com/divio/aldryn-newsblog/issues/522

I can make a PR later today if it helps.

Thanks!

Marcos

marcosguedes commented 5 years ago

Stacktrace

File "/home/marcos/.virtualenvs/myproject/lib/python3.6/site-packages/djangocms_page_sitemap/cms_toolbars.py" in populate
  41.             not_edit_mode = not self.toolbar.edit_mode

Exception Type: AttributeError at /
Exception Value: 'CMSToolbar' object has no attribute 'edit_mode'
jeroenpeters1986 commented 5 years ago

I just created a PR for this which is backwards compatible

marcosguedes commented 5 years ago

Awesome! I completely forgot to look at it this weekend

jeroenpeters1986 commented 5 years ago

Awesome! I completely forgot to look at it this weekend

Not a problem, I just encountered this when I wanted to update my own installation to Django 3.6

marcosguedes commented 5 years ago

@jeroenpeters1986 You might also find interest in creating a PR for this issue as well https://github.com/nephila/djangocms-page-meta/issues/99

If not, I'll set a reminder to update it with your fix (and leave credits)

jeroenpeters1986 commented 5 years ago

@jeroenpeters1986 You might also find interest in creating a PR for this issue as well nephila/djangocms-page-meta#99

If not, I'll set a reminder to update it with your fix (and leave credits)

Will do :-)