search

nephila / djangocms-page-sitemap

django CMS page extension to handle sitemap customization
BSD 3-Clause "New" or "Revised" License
9 stars 20 forks source link

Compatibility with Django-CMS 3.7.2 #52

Closed fp4code closed 4 years ago

fp4code commented 4 years ago

python_2_unicode_compatible is no more defined in cms.utils.compat.dj

See https://forum.djangoproject.com/t/python-2-unicode-compatible/715

fp4code commented 4 years ago

python_2_unicode_compatible is no more defined in django-3.

yakky commented 4 years ago

@fp4code thanks for your PR :tada: I will open a separate PR to fix the tests (which are currently broken on py27 / django CMS 3.7.2) and I will rebase your PR after that

yakky commented 4 years ago

@fp4code I cannot rebase this, could you please rebase on current develop? After this I will be able to re-enable django CMS 3.7.2 test and release a fix Django 3.0 support will follow soon

yakky commented 4 years ago

@fp4code never mind, it's easier if I can merge this as is, fix don't require a clean run