search

nephila / djangocms-page-sitemap

django CMS page extension to handle sitemap customization
BSD 3-Clause "New" or "Revised" License
9 stars 21 forks source link

Use the correct toolbar for versioning and django-cms v4 #59

Closed Aiky30 closed 4 years ago

Aiky30 commented 4 years ago

The Toolbar is fundamentally broken in V4 when versioning is installed. The placeholder toolbar is responsible for adding the Create and Edit buttons, when the Placeholder toolbar is extended a duplicate instance is created causing duplicated buttons to be created.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 0.0% when pulling 419b7a9ab28b41012db8fe6a96cad9f69670bff1 on Aiky30:bugfix/use-the-correct-toolbar-for-versioning-and-cms-v4 into 07d00b855bd20854a824410e74c44199ff7bc401 on nephila:support/4.0.x.

Aiky30 commented 4 years ago

@yakky Can you please review the changes in this PR for the support/4.0.x branch.

Aiky30 commented 4 years ago

@yakky Are you able to review the changes in this PR please? I'm not sure if a similar change would be required in master because the wrong toolbar is used, CMSToolbar creates the toolbar buttons, PageToolbar just adds additional page specific functionality.

Aiky30 commented 4 years ago

@yakky Are you able to review this PR for us please? The wrong toolbar is used for v4 and creates multiple buttons, it breaks out projects if you select the wrong button.