nephila / djangocms-page-sitemap

django CMS page extension to handle sitemap customization
BSD 3-Clause "New" or "Revised" License
9 stars 20 forks source link

feat: Backport cms 4.0.x - Django 3.2 with Python 3.8 & 3.9 support, including update tooling #70

Open Aiky30 opened 2 years ago

Aiky30 commented 2 years ago

Description

Describe:

References

Changes ported from: https://github.com/nephila/djangocms-page-sitemap/commit/05c93d561c96185fc44f48342fab8886c1662505

Checklist

coveralls commented 2 years ago

Coverage Status

Coverage increased (+95.5%) to 95.506% when pulling 774ff10c7d0d20cdecc37b247e307c65ae375bcd on Aiky30:feature/cms4-support-update-tooling into 9846374d93514756cbafaab7cd8f923e4e53631f on nephila:support/4.0.x.

codecov[bot] commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (support/4.0.x@9846374). Click here to learn what that means. The diff coverage is n/a.

:exclamation: Current head 774ff10 differs from pull request most recent head acc9942. Consider uploading reports for the commit acc9942 to get more accurate results Impacted file tree graph

@@               Coverage Diff                @@
##             support/4.0.x      #70   +/-   ##
================================================
  Coverage                 ?   94.44%           
================================================
  Files                    ?        8           
  Lines                    ?      180           
  Branches                 ?       22           
================================================
  Hits                     ?      170           
  Misses                   ?        8           
  Partials                 ?        2           
Flag Coverage Δ
unittests 94.44% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9846374...acc9942. Read the comment docs.

joshyu commented 3 months ago

Hi @Aiky30 , Is this PR still in progress? I want to add Django4.2 support based on your PR.

Aiky30 commented 3 months ago

Hi @joshyu,

Sadly this was never accepted by Nephila. This is potentially an issue because any changes that you make would only compound the sheer amount of changes.