search

nephila / giturlparse

Parse & rewrite git urls (supports GitHub, Bitbucket, Assembla ...)
https://pypi.python.org/pypi/giturlparse
Apache License 2.0
31 stars 22 forks source link

Should not this be a branch? #55

Open feliam opened 1 year ago

feliam commented 1 year ago

https://github.com/nephila/giturlparse/blob/a6b48dad230d43393227ffdf52f2099db8038622/giturlparse/tests/test_parse.py#L381

    from giturlparse import parse as giturlparse
    p = giturlparse("https://github.com/nephila/giturlparse/tree/master/changes")
    print (p.branch, p.path)
    assert p.branch == "master"
    assert p.path == "changes"
protoroto commented 1 year ago

@feliam The url you're referring to in test_parse.py is https://github.com/nephila/giturlparse/blob/master/giturlparse/github.py , but you did test https://github.com/nephila/giturlparse/tree/master/changes , that is a different url.

Or am I missing something here?