Closed boozec closed 1 year ago
:exclamation: No coverage uploaded for pull request base (
master@f34ffa8
). Click here to learn what that means. Patch has no changes to coverable lines.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@boozec Hi! Thanks for the contribution! Two minor things:
bugfix/issue-42-gitlab-url-with-branch
otherwise towncrier check will fail...-
... are there still tests without the -
?
Thanks again, looking forward to merge this!Hi @protoroto sorry but the rename deleted this PR :sweat_smile: i'm reopening and added another test without -
in both name and before the "/blob" :)
edit: there is a test (the old one) at https://github.com/nephila/giturlparse/pull/74/files#diff-75ab2ceadb20388b5d32a82bda0f5ad26298c06693e55bd3947be19a6d429606R437
Hi all :wave:
Description
Gitlab URLs has the format with "/-/blob/". This PR fixs the parser editing the FORMAT string with the "/-/" before the ('blob'|'tree').
eg: The string "https://gitlab.com/gitlab-org/gitlab/blob/master/README.md" is valid as "https://gitlab.com/gitlab-org/gitlab/-/blob/master/README.md".
References
Fixs https://github.com/nephila/giturlparse/issues/42
Checklist
inv lint