search

nephila / python-taiga

:evergreen_tree: Python module for communicating with the Taiga API
https://python-taiga.readthedocs.io
MIT License
94 stars 41 forks source link

Bugfix/issue 149 wiki page version #151

Closed heieisch closed 9 months ago

heieisch commented 9 months ago

Description

fix issue 149 as discussed. Adds the version parameter to the allowed_params, so the requester can access it.

now with correct branch name

References

GitHub issue 149 fixed

Checklist

coveralls commented 9 months ago

Coverage Status

coverage: 97.921%. remained the same when pulling 6fac4d0e12a48714c55ea7342ffcca72e6fdc32b on heieisch:bugfix/issue-149-WikiPage-version into 7d717c6e60ac433f94d07b8bb11fdd1c3747b6c3 on nephila:master.

codecov[bot] commented 9 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (7d717c6) 96.49% compared to head (6fac4d0) 96.49%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #151 +/- ## ======================================= Coverage 96.49% 96.49% ======================================= Files 8 8 Lines 914 914 Branches 69 69 ======================================= Hits 882 882 Misses 19 19 Partials 13 13 ``` | [Flag](https://app.codecov.io/gh/nephila/python-taiga/pull/151/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nephila) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/nephila/python-taiga/pull/151/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nephila) | `96.49% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nephila#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/nephila/python-taiga/pull/151?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nephila) | Coverage Δ | | |---|---|---| | [taiga/models/models.py](https://app.codecov.io/gh/nephila/python-taiga/pull/151?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=nephila#diff-dGFpZ2EvbW9kZWxzL21vZGVscy5weQ==) | `96.53% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

protoroto commented 9 months ago

@heieisch I'm about to release a new version with your fix, and I wanted to update the AUTHORS file with your name and email, if you're ok with that, but I don't know them :) if you want to be included, please write them here (or if you prefer, via email at l.cavallucci@nephila.digital ) Thanks again