search

nephio-experimental / one-summit-22-workshop

Apache License 2.0
6 stars 34 forks source link

ensures ingress-ready label is added to control-plane node of mgmt cluster #151

Closed vjayaramrh closed 1 year ago

vjayaramrh commented 1 year ago

In order to be able to re-use the ansible scripts for non-KIND clusters as well, this PR enhances the nephio/deploy role to ensure that ingress-ready=true gets added to the control-plane node of the mgmt cluster before applying the ingress KRM resource

vjayaramrh commented 1 year ago

cc: @henderiw @johnbelamaric @s3wong

henderiw commented 1 year ago

/lgtm

nephio-prow[bot] commented 1 year ago

@henderiw: changing LGTM is restricted to collaborators

In response to [this](https://github.com/nephio-project/one-summit-22-workshop/pull/151#issuecomment-1522771109): >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
johnbelamaric commented 1 year ago

Presumably, though, this still works for KinD clusters?

vjayaramrh commented 1 year ago

Presumably, though, this still works for KinD clusters?

Yes, The KIND clusters already have the label set and reapplying a label again does not cause any issues

johnbelamaric commented 1 year ago

/approve /lgtm

nephio-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: johnbelamaric, vjayaramrh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/nephio-project/one-summit-22-workshop/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
johnbelamaric commented 1 year ago

Oh, we don't really have Prow set up in this repo.

In fact, I am hoping we can retire this repo and archive it. I guess after R1 - the code in here should be obsolete after we have our packaging and installation for R1 done.