search

nephio-experimental / one-summit-22-workshop

Apache License 2.0
6 stars 34 forks source link

allows for specifying master interface value for clusters to be consumed in cluster-context #152

Closed vjayaramrh closed 1 year ago

vjayaramrh commented 1 year ago

This PR adds support for specifying a different value for the master interface other than the current hard coded eth1 value which works only for KIND clusters created by ansible scripts. This would support non-KIND clusters pre-deployed with API server accessible on a different interface name.

nephio-prow[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vjayaramrh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/nephio-project/one-summit-22-workshop/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
vjayaramrh commented 1 year ago

cc: @henderiw @johnbelamaric @s3wong