search

nephio-project / nephio

Nephio is a Kubernetes-based automation platform for deploying and managing highly distributed, interconnected workloads such as 5G Network Functions, and the underlying infrastructure on which those workloads depend.
Apache License 2.0
104 stars 53 forks source link

Upgrade Nephio to Go 1.22 #597

Closed liamfallon closed 4 months ago

liamfallon commented 5 months ago

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line: /kind bug

/kind cleanup

/kind design /kind documentation /kind failing-test /kind feature /kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes: Fixes Issue 510.

Special notes for your reviewer:

Does this PR introduce a user-facing change?: no

nephio-prow[bot] commented 5 months ago

@liamfallon: The label(s) kind/cleanup cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/nephio-project/nephio/pull/597): >**What type of PR is this?** > >> Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line: >> /kind bug > >/kind cleanup > >> /kind design >> /kind documentation >> /kind failing-test >> /kind feature >> /kind flake > >**What this PR does / why we need it:** > >- Updated go version in go.mod files >- Updated go version in github workflows >- Updated base image to 1.22.2-bookworm in Dockerfiles >- Updated Go/Golang-CI/GoSec versions in makefiles >- Updated reflect.TypeOf() to reflect.TypeFor[]() where relevant > >**Which issue(s) this PR fixes:** >Fixes [Issue 510](https://github.com/nephio-project/nephio/issues/510). > >**Special notes for your reviewer:** > >**Does this PR introduce a user-facing change?:** >no > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
liamfallon commented 5 months ago

The go tests need to be upgraded to Go 1.22, see https://github.com/nephio-project/test-infra/pull/258

liamfallon commented 5 months ago

/hold

liamfallon commented 5 months ago

/retest

liamfallon commented 5 months ago

/retest

radoslawc commented 5 months ago

/retest

liamfallon commented 5 months ago

/retest

liamfallon commented 5 months ago

The toolchain has been updated for go 1.22 now, thanks to @radoslawc. This PR is ready for review. /assign @tliron @efiacor @vjayaramrh

efiacor commented 5 months ago

/approve

nephio-prow[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efiacor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nephio-project/nephio/blob/main/OWNERS)~~ [efiacor] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
efiacor commented 4 months ago

/lgtm