nephio-project / nephio

Nephio is a Kubernetes-based automation platform for deploying and managing highly distributed, interconnected workloads such as 5G Network Functions, and the underlying infrastructure on which those workloads depend.
Apache License 2.0
93 stars 52 forks source link

Figure out blueprint detection from tags. vs. main branch #605

Open liamfallon opened 2 months ago

liamfallon commented 2 months ago

Original issue URL: https://github.com/kptdev/kpt/issues/3269 Original issue user: https://github.com/mortent Original issue created at: 2022-05-27T21:52:25Z Original issue last updated at: 2022-05-27T21:52:25Z Original issue body: Should we:

We have already added functionality that tags the latest revision (https://github.com/GoogleContainerTools/kpt/pull/3015).

Original issue comments:

liamfallon commented 1 month ago

This is to do with a PackageRevision being created for main.

Blueprints: When you approve, Porch commits the package to main and creates a tag. So there are two PackageRevision instances created, one for the tag and another for main.

We need to rethink how this works because this automatically created PackageRevision is confusing for users.

The discovery function should not rely on the main PackageRevision.

Deployment:

This PackageRevision is also used for deployment. The main PacakgeRevision may have been created for deployment.

henderiw commented 1 month ago

Here is the code related to this issue.

https://github.com/nephio-project/porch/blob/1754fc8fd09f799471d0916c50921b0b27aef50d/pkg/git/git.go#L262

liamfallon commented 1 month ago

Triaged Triage Comment: Part of Porch rearchitecture