search

nephio-project / nephio

Nephio is a Kubernetes-based automation platform for deploying and managing highly distributed, interconnected workloads such as 5G Network Functions, and the underlying infrastructure on which those workloads depend.
Apache License 2.0
104 stars 53 forks source link

Fix race condition in Porch #610

Open liamfallon opened 5 months ago

liamfallon commented 5 months ago

Original issue URL: https://github.com/kptdev/kpt/issues/3661 Original issue user: https://github.com/mortent Original issue created at: 2022-11-16T05:16:55Z Original issue last updated at: 2022-11-16T05:16:55Z Original issue body: Porch is using the go-git library from multiple threads (background poller and the requests) and it seems like the library is not thread safe. Example of how to reproduce this problem in https://github.com/GoogleContainerTools/kpt/pull/3602

Original issue comments:

nagygergo commented 4 months ago

Probably already fixed by https://github.com/kptdev/kpt/pull/3900

liamfallon commented 3 months ago

Yes, this seems to be fixed, the code mentioned in https://github.com/kptdev/kpt/pull/3602 has been refactored.