Nephio is a Kubernetes-based automation platform for deploying and managing highly distributed, interconnected workloads such as 5G Network Functions, and the underlying infrastructure on which those workloads depend.
Apache License 2.0
104
stars
53
forks
source link
porch: packagevariant leaves lingering packages after an error during delete #642
Original issue URL: https://github.com/kptdev/kpt/issues/3878
Original issue user: https://github.com/johnbelamaric
Original issue created at: 2023-03-13T19:06:04Z
Original issue last updated at: 2023-03-18T00:18:30Z
Original issue body: ### Expected behavior
Package variant resource will not be finalized until the underlying package revisions are deleted.
Actual behavior
If an error occurs during deletion, the resource is still deleted but the revision remains.
Information
I think that's what happened.
I have two PackageVariantSets. One targets the "edge" package at "edge" repos, the other targets the "distribution" package at "regional" repos.
Notice the second line here - the "distribution" package in the "edge-02" repo.
Initially, I messed up my label selectors and ended up with both packages in every repo. I fixed, that, and it most packages got cleaned up. But this one lingers. On top of that, this is the same repo exhibiting #3877 so that may be related.
Below are some logs. During the course of these log entries, I:
Created a bogus repo (jbelamaric-us-regional-1-edge-01). You can ignore errors related to that.
Updated all the repos to point to a new GH repos - that is why the initial errors complain about not being allowed to create outside of the directory, then those errors go away. You can ignore those, I filed a separate issue for that.
Created to PVSs with no label selectors, which resulted in lots too many packages.
Modified those PVSs to have the right label selectors, which resulted in most getting cleaned up as expected.
Original issue URL: https://github.com/kptdev/kpt/issues/3878 Original issue user: https://github.com/johnbelamaric Original issue created at: 2023-03-13T19:06:04Z Original issue last updated at: 2023-03-18T00:18:30Z Original issue body: ### Expected behavior Package variant resource will not be finalized until the underlying package revisions are deleted.
Actual behavior
If an error occurs during deletion, the resource is still deleted but the revision remains.
Information
I think that's what happened.
I have two PackageVariantSets. One targets the "edge" package at "edge" repos, the other targets the "distribution" package at "regional" repos.
Notice the second line here - the "distribution" package in the "edge-02" repo.
Initially, I messed up my label selectors and ended up with both packages in every repo. I fixed, that, and it most packages got cleaned up. But this one lingers. On top of that, this is the same repo exhibiting #3877 so that may be related.
Below are some logs. During the course of these log entries, I: