Nephio is a Kubernetes-based automation platform for deploying and managing highly distributed, interconnected workloads such as 5G Network Functions, and the underlying infrastructure on which those workloads depend.
Apache License 2.0
104
stars
53
forks
source link
porch should support cloning an abstract package even when `fn render` operation fails. #652
Ghost application package has a validation function that helps user discover required inputs (hostname in this case) for the package. So cloning ghost package in deployment repo leads to an incomplete package with fn render failing reporting an expected failure.
One can reach this state while editing a package as well (imagine a mis-configuration).
So the expected behavior here is porch should allow saving (and cloning) the package state even in these mis-configuration scenario.
Original issue comments:
Comment user: https://github.com/droot
Comment created at: 2022-08-01T19:15:49Z
Comment last updated at: 2022-08-01T19:15:49Z
Comment body: /cc @ChristopherFry
Comment user: https://github.com/johnbelamaric
Comment created at: 2022-08-01T19:39:25Z
Comment last updated at: 2022-08-01T19:39:25Z
Comment body: As we discussed earlier, it probably should block Proposing - but allow the cloning and saving. So it has to stay a Draft until it passes all validators.
Comment user: https://github.com/droot
Comment created at: 2022-08-02T17:25:16Z
Comment last updated at: 2022-08-02T17:25:16Z
Comment body: > As we discussed earlier, it probably should block Proposing - but allow the cloning and saving. So it has to stay a Draft until it passes all validators.
Original issue URL: https://github.com/kptdev/kpt/issues/3424 Original issue user: https://github.com/droot Original issue created at: 2022-08-01T19:15:29Z Original issue last updated at: 2023-01-26T04:38:19Z Original issue body: Sharing more background here:
Ghost application package has a validation function that helps user discover required inputs (hostname in this case) for the package. So cloning ghost package in deployment repo leads to an incomplete package with
fn renderfailing reporting an expected failure.One can reach this state while editing a package as well (imagine a mis-configuration).
So the expected behavior here is porch should allow saving (and cloning) the package state even in these mis-configuration scenario.
Original issue comments: Comment user: https://github.com/droot Comment created at: 2022-08-01T19:15:49Z Comment last updated at: 2022-08-01T19:15:49Z Comment body: /cc @ChristopherFry
Comment user: https://github.com/johnbelamaric Comment created at: 2022-08-01T19:39:25Z Comment last updated at: 2022-08-01T19:39:25Z Comment body: As we discussed earlier, it probably should block Proposing - but allow the cloning and saving. So it has to stay a Draft until it passes all validators.
Comment user: https://github.com/droot Comment created at: 2022-08-02T17:25:16Z Comment last updated at: 2022-08-02T17:25:16Z Comment body: > As we discussed earlier, it probably should block Proposing - but allow the cloning and saving. So it has to stay a Draft until it passes all validators.
+1.