Nephio is a Kubernetes-based automation platform for deploying and managing highly distributed, interconnected workloads such as 5G Network Functions, and the underlying infrastructure on which those workloads depend.
Apache License 2.0
93
stars
52
forks
source link
porch: packagevariant and packagevariantset should expose errors in the status #674
Original issue URL: https://github.com/kptdev/kpt/issues/3891
Original issue user: https://github.com/ChristopherFry
Original issue created at: 2023-03-21T20:50:04Z
Original issue last updated at: 2023-03-30T03:56:01Z
Original issue body: Currently, the PackageVariant and PackageVariantSet do not expose errors in the status. Adding errors to the PackageVariant and PackageVariantSet status will make it obvious to the user that the resources are in an error state rather than the user needing to check the logs or uncertain if the resources have yet to been reconciled.
For example, when creating a PackageVariantSet using the ghost package from the kpt-samples repository, the target PackageRevision is not being created due to a rendering error. This can be seen in the controller logs (error Internal error occurred: fn.render: pkg .:\n\tpkg.render: pkg ghost-app:\n\tpipeline.run: error: function failure) however it is not obvious to the user when looking at the resources using kubectl.
Comment user: https://github.com/johnbelamaric
Comment created at: 2023-03-21T21:07:09Z
Comment last updated at: 2023-03-21T21:07:09Z
Comment body: It should probably fire off K8s events as well.
Original issue URL: https://github.com/kptdev/kpt/issues/3891 Original issue user: https://github.com/ChristopherFry Original issue created at: 2023-03-21T20:50:04Z Original issue last updated at: 2023-03-30T03:56:01Z Original issue body: Currently, the PackageVariant and PackageVariantSet do not expose errors in the status. Adding errors to the PackageVariant and PackageVariantSet status will make it obvious to the user that the resources are in an error state rather than the user needing to check the logs or uncertain if the resources have yet to been reconciled.
For example, when creating a PackageVariantSet using the ghost package from the kpt-samples repository, the target PackageRevision is not being created due to a rendering error. This can be seen in the controller logs (error
Internal error occurred: fn.render: pkg .:\n\tpkg.render: pkg ghost-app:\n\tpipeline.run: error: function failure
) however it is not obvious to the user when looking at the resources usingkubectl
.Example PackageVariantSet yaml:
Inspecting the PackageVariantSet and PackageVariant using
kubectl
does not show the error:cc @johnbelamaric
Original issue comments: Comment user: https://github.com/natasha41575 Comment created at: 2023-03-21T21:01:43Z Comment last updated at: 2023-03-21T21:01:43Z Comment body: Thanks for filing the issue! This is tangentially related to https://github.com/GoogleContainerTools/kpt/issues/3872
Comment user: https://github.com/johnbelamaric Comment created at: 2023-03-21T21:07:09Z Comment last updated at: 2023-03-21T21:07:09Z Comment body: It should probably fire off K8s events as well.