search

nephio-project / nephio

Nephio is a Kubernetes-based automation platform for deploying and managing highly distributed, interconnected workloads such as 5G Network Functions, and the underlying infrastructure on which those workloads depend.
Apache License 2.0
93 stars 52 forks source link

PackageRevision label selection does not work #690

Closed liamfallon closed 1 month ago

liamfallon commented 3 months ago

Original issue URL: https://github.com/kptdev/kpt/issues/3401 Original issue user: https://github.com/johnbelamaric Original issue created at: 2022-07-21T19:45:49Z Original issue last updated at: 2023-01-26T04:12:11Z Original issue body: ### Expected behavior I can use kubectl get packagerevision -l 'kpt.dev/latest-revision=true' to see the latest version of the packages.

Actual behavior

All package revisions are returned. I suspect this is because it's an aggregated API server so we would have to implement this ourselves (maybe another reason to use CRDs instead):

jbelamaric@jbelamaric:~/proj/nephio-dev-deploy$ k get packagerevision -l 'kpt.dev/latest-revision=true' -n default
NAME                                                         PACKAGE           REVISION   LATEST   LIFECYCLE   REPOSITORY
nephio-dev-deploy-6fe89b83a578123d9bd58556360555c30676e0d1   dnscache          main       false    Published   nephio-dev-deploy
nephio-dev-deploy-ecbbc233c9caa49916422f5a35f770f17eebed4d   dnscache          v1         true     Published   nephio-dev-deploy
nephio-dev-deploy-0247f2adfd09fa113737ab033918095bdfaf16eb   dnscache          v2         false    Draft       nephio-dev-deploy
nephio-packages-e01d890d4c85fc62299d956829ffe948d712bd76     coredns-caching   main       false    Published   nephio-packages
nephio-packages-1324babaaf974f13daea7cb675934ab8a616ed89     coredns-caching   v0.1       false    Published   nephio-packages
nephio-packages-edfea244e9255e476de3dcc00b56003104f1d4cd     coredns-caching   v1         false    Published   nephio-packages
nephio-packages-8f6ade1048c5a7da0d8364d5c82026339f4950ad     coredns-caching   v2         false    Published   nephio-packages
nephio-packages-903eb7670936cc2ba4d5f6325ab9f15da80bc5c8     coredns-caching   v3         false    Published   nephio-packages
nephio-packages-85e491a3bbf7203345e75cb7dd76ae7e3b07c21e     coredns-caching   v4         true     Published   nephio-packages

Information

Steps to reproduce the behavior

Original issue comments: Comment user: https://github.com/mortent Comment created at: 2023-01-26T04:12:11Z Comment last updated at: 2023-01-26T04:12:11Z Comment body: Yeah, since we are looking to migrate to CRDs, we probably want to hold off on this until then.

kushnaidu commented 1 month ago

I cannot reproduce the issue. 

ubuntu@nephio-test-vm-01:~$ k get packagerevision -l 'kpt.dev/latest-revision=true' -n default
NAME                                                                 PACKAGE                              WORKSPACENAME   REVISION   LATEST   LIFECYCLE   REPOSITORY
catalog-distros-sandbox-73199490526a7d92d96febe7f807f568ebb88d20     cert-manager                         v2.0.0          v2.0.0     true     Published   catalog-distros-sandbox
catalog-distros-sandbox-4e65c41b88034231a29fe21b2e74279b0e9b2404     gitea                                v2.0.0          v2.0.0     true     Published   catalog-distros-sandbox
catalog-distros-sandbox-793aa10deb15f0e4d0ec2cf105fd9dc215fa2b22     metallb                              v2.0.0          v2.0.0     true     Published   catalog-distros-sandbox
catalog-distros-sandbox-88391410ededcde07d6007a1ae889451e2165e2e     metallb-sandbox-config               v2.0.0          v2.0.0     true     Published   catalog-distros-sandbox
catalog-distros-sandbox-79780277c280708e8961ec67680005a03449e276     network                              v2.0.0          v2.0.0     true     Published   catalog-distros-sandbox
catalog-distros-sandbox-bb4ff26c3f34cc8bf7c4f8ef50f40bb52c38e892     repository                           v2.0.0          v2.0.0     true     Published   catalog-distros-sandbox
catalog-infra-capi-9d7631f1da91f574c14e0c32dac05f408a6e1fbb          cluster-capi                         v2.0.0          v2.0.0     true     Published   catalog-infra-capi
catalog-infra-capi-e9fd22623bb201937c988c84f44bf59e13da8312          cluster-capi-infrastructure-docker   v2.0.0          v2.0.0     true     Published   catalog-infra-capi
catalog-infra-capi-a7bbcb0323f1decc7051a3592520bc1cb9ddb0e1          cluster-capi-kind                    v2.0.0          v2.0.0     true     Published   catalog-infra-capi
catalog-infra-capi-735173d1a0716e28b157c1fb571b2c80b8c5d01d          cluster-capi-kind-docker-templates   v2.0.0          v2.0.0     true     Published   catalog-infra-capi
catalog-infra-capi-61b1aa01584a55962aab0290a609a8631f933a41          kindnet                              v2.0.0          v2.0.0     true     Published   catalog-infra-capi
catalog-infra-capi-11a41f649e049f5ac2112be97d09b90048a15df2          local-path-provisioner               v2.0.0          v2.0.0     true     Published   catalog-infra-capi
catalog-infra-capi-f96451f6566a61c10aae6351aa6a5e95c1cec52c          multus                               v2.0.0          v2.0.0     true     Published   catalog-infra-capi
catalog-infra-capi-b0ae9512aab3de73bbae623a3b554ade57e15596          nephio-workload-cluster              v2.0.0          v2.0.0     true     Published   catalog-infra-capi
catalog-infra-capi-1aeca88ba6a382a9b34f1ad98aa6913b391c8992          vlanindex                            v2.0.0          v2.0.0     true     Published   catalog-infra-capi
catalog-nephio-core-ffcb38d6498b5b46c204a7e0b14e2054f4a0a1d0         configsync                           v2.0.0          v2.0.0     true     Published   catalog-nephio-core
catalog-nephio-core-04fa4e7d6ba6211f9e5764bab26fad0ba6785fe3         nephio-operator                      v2.0.0          v2.0.0     true     Published   catalog-nephio-core
catalog-nephio-core-b203eed1fa12dd9afe1ad55f931d0367845ca79e         porch                                v2.0.0          v2.0.0     true     Published   catalog-nephio-core
catalog-nephio-core-6f7b03616f7155271de61ee7aea72d6d402ba275         workload-crds                        v2.0.0          v2.0.0     true     Published   catalog-nephio-core
catalog-nephio-optional-7bc45ffb09a8c36c30dd31d99099a7cf94f2a93e     flux-helm-controllers                v2.0.0          v2.0.0     true     Published   catalog-nephio-optional
catalog-nephio-optional-81ed4a63098c09100ae08bee712050f70afb8f25     network-config                       v2.0.0          v2.0.0     true     Published   catalog-nephio-optional
catalog-nephio-optional-4329f908b97b94803ad79f7ad72d6183e9abb3bb     resource-backend                     v2.0.0          v2.0.0     true     Published   catalog-nephio-optional
catalog-nephio-optional-654d97eec2260170951626925ab137de303c822d     rootsync                             v2.0.0          v2.0.0     true     Published   catalog-nephio-optional
catalog-nephio-optional-41e00a633b17e635a9317430b44a4d8aaae1d97c     stock-repos                          v2.0.0          v2.0.0     true     Published   catalog-nephio-optional
catalog-nephio-optional-2b480988308d057493b96657771124e8ec8cc9a5     webui                                v2.0.0          v2.0.0     true     Published   catalog-nephio-optional
catalog-workloads-free5gc-4e603deea605173c6b4a6cd18b14e2687e265bec   free5gc-cp                           v2.0.0          v2.0.0     true     Published   catalog-workloads-free5gc
catalog-workloads-free5gc-52e841ecc8fe95ae3fcb26fa66c44e6664e6eeea   free5gc-operator                     v2.0.0          v2.0.0     true     Published   catalog-workloads-free5gc
catalog-workloads-free5gc-5195d96eaa09835ba3af68ffe3b98c31f24ad3ec   pkg-example-amf-bp                   v2.0.0          v2.0.0     true     Published   catalog-workloads-free5gc
catalog-workloads-free5gc-da60e2c285526324117a67e5041f5f8c04c1623b   pkg-example-smf-bp                   v2.0.0          v2.0.0     true     Published   catalog-workloads-free5gc
catalog-workloads-free5gc-1fd227bcd55128eb1d18542220d889162b964887   pkg-example-upf-bp                   v2.0.0          v2.0.0     true     Published   catalog-workloads-free5gc
catalog-workloads-oai-ran-cfd7e3898608b30bf4929272c3d32e3c2edea3cd   oai-ran-operator                     v2.0.0          v2.0.0     true     Published   catalog-workloads-oai-ran
catalog-workloads-oai-ran-fe925f2b8ce062a86390b8b4adf3d6190b159c2e   pkg-example-cucp-bp                  v2.0.0          v2.0.0     true     Published   catalog-workloads-oai-ran
catalog-workloads-oai-ran-91042101ce486d444e7cedc2250f9d6d23b5b682   pkg-example-cuup-bp                  v2.0.0          v2.0.0     true     Published   catalog-workloads-oai-ran
catalog-workloads-oai-ran-fee3b3e87b7a3a80c22e7833d3118880517b4e11   pkg-example-du-bp                    v2.0.0          v2.0.0     true     Published   catalog-workloads-oai-ran
catalog-workloads-oai-ran-99d7650ccab31c7434159780793909eab104b86b   pkg-example-ue-bp                    v2.0.0          v2.0.0     true     Published   catalog-workloads-oai-ran
catalog-workloads-tools-163d4171f0e301986585fdce810f769edbce845b     ueransim                             v2.0.0          v2.0.0     true     Published   catalog-workloads-tools
oai-core-packages-5c318830bb58c1e0389710e6d47dd5cfb86017ac           database                             v2.0.0          v2.0.0     true     Published   oai-core-packages
oai-core-packages-87069d1be8a1def48355e04ffb715244a8a53359           oai-amf                              v2.0.0          v2.0.0     true     Published   oai-core-packages
oai-core-packages-1a791345c40251ef48e4b2559fbe4245fdf11639           oai-ausf                             v2.0.0          v2.0.0     true     Published   oai-core-packages
oai-core-packages-7e63c3bc1d1cd3f1d8c251b610841fea3d840440           oai-cp-operators                     v2.0.0          v2.0.0     true     Published   oai-core-packages
oai-core-packages-cdeb659fd4a8f1c59703a65602072f302efef069           oai-nrf                              v2.0.0          v2.0.0     true     Published   oai-core-packages
oai-core-packages-c9a320c68a11777820ebfa58596424ca0e7568da           oai-udm                              v2.0.0          v2.0.0     true     Published   oai-core-packages
oai-core-packages-92efa067f1b83443d36c0f5f9850e7462db344e1           oai-udr                              v2.0.0          v2.0.0     true     Published   oai-core-packages
oai-core-packages-ff08112ec793baa65e0f6c1699360e31393b0b73           oai-up-operators                     v2.0.0          v2.0.0     true     Published   oai-core-packages
oai-core-packages-44cb0b3802350be84ec4eadcc55115d87117ddca           oai-upf-edge                         v2.0.0          v2.0.0     true     Published   oai-core-packages

ubuntu@nephio-test-vm-01:~$ kubectl get packagerevision -l 'fake/label=true'
No resources found in default namespace.

Issue is fixed - https://github.com/Nordix/porch/blob/a03a8d2379b5f76a0da9b4123edb75f1b906ab83/pkg/registry/porch/packagecommon.go#L84

kushnaidu commented 1 month ago

The issue is already fixed and reproducible. closing the ticket.