nephio-project / nephio

Nephio is a Kubernetes-based automation platform for deploying and managing highly distributed, interconnected workloads such as 5G Network Functions, and the underlying infrastructure on which those workloads depend.
Apache License 2.0
93 stars 52 forks source link

Change the k8s resource names of Functions #692

Open liamfallon opened 3 months ago

liamfallon commented 3 months ago

Original issue URL: https://github.com/kptdev/kpt/issues/3267 Original issue user: https://github.com/mortent Original issue created at: 2022-05-27T17:59:35Z Original issue last updated at: 2023-01-13T12:36:37Z Original issue body: Packages and functions (both in OCI and Git) can contain characters disallowed in k8s resource names.

We have renamed packages https://github.com/GoogleContainerTools/kpt/pull/3007 and need to follow up with function resources as well.

Original issue comments: Comment user: https://github.com/yuwenma Comment created at: 2023-01-13T12:35:12Z Comment last updated at: 2023-01-13T12:35:12Z Comment body: I'm trying to clarify the requirements of this issue. @mortent Can you give an example of Function resource that uses invalid k8s names? If this is for future awareness of avoiding invalid k8s resources in KRM functions, I think we then need to add a CI test in the function catalog repo

Comment user: https://github.com/yuwenma Comment created at: 2023-01-13T12:36:36Z Comment last updated at: 2023-01-13T12:36:36Z Comment body: I read the #3007 PR Morten linked. The "Function" here refers to the porch "Function" resources, not the KRM function images.