nephio-project / nephio

Nephio is a Kubernetes-based automation platform for deploying and managing highly distributed, interconnected workloads such as 5G Network Functions, and the underlying infrastructure on which those workloads depend.
Apache License 2.0
93 stars 52 forks source link

Disallow self-approval of packages #716

Open liamfallon opened 3 months ago

liamfallon commented 3 months ago

Original issue URL: https://github.com/kptdev/kpt/issues/3265 Original issue user: https://github.com/mortent Original issue created at: 2022-05-27T17:41:42Z Original issue last updated at: 2022-05-27T17:41:42Z Original issue body: Currently we allow users to both propose and approve a package. We should make it possible to disallow self-approval of packages, so that either another individual or some automated process are required for approval.

One option here might be to leverage k8s rbac since approval is a separate subresource. But it might not provide the necessary granularity.

Original issue comments: