search

nephio-project / nephio

Nephio is a Kubernetes-based automation platform for deploying and managing highly distributed, interconnected workloads such as 5G Network Functions, and the underlying infrastructure on which those workloads depend.
Apache License 2.0
93 stars 52 forks source link

packagevariant does not fail when function rendering does not happen for target package #730

Closed s375kuma closed 6 days ago

s375kuma commented 1 month ago

Hi,

I created a packagevariant and in the pipeline provided wrong function image. The package was cloned to target properly but the function rendering was not executed due to wrong image. After some time pacakgevariant status was updated as ready true which I think is wrong and there were no events registered for the function rendering failure.

kispaljr commented 1 week ago

If the cloning to the downstream package is successful, but the rendering fails, it isn't considered as an error by design. The reason behind this is that the PackageVariant successfully performed its job, and the rendering error is caused by the package author.

At the same time the wish to expose those errors via the status of the PackageVariant is absolutely justified. PR https://github.com/nephio-project/porch/pull/75 is trying to fix this.