nephio-project / nephio

Nephio is a Kubernetes-based automation platform for deploying and managing highly distributed, interconnected workloads such as 5G Network Functions, and the underlying infrastructure on which those workloads depend.
Apache License 2.0
93 stars 52 forks source link

Manual CodeQL configuration to mitigate tide merging problems #734

Closed radoslawc closed 1 month ago

radoslawc commented 1 month ago

CodeQL default setup has been causing problems by not recognising golang, adding manual configuration.

radoslawc commented 1 month ago

@tliron @henderiw this will have to be merged manually since 'old' codeql is hanging there, but the one with manual configuration has passed.

radoslawc commented 1 month ago

/override "Code scanning results / CodeQL"

nephio-prow[bot] commented 1 month ago

@radoslawc: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/nephio-project/nephio/pull/734#issuecomment-2110699508): >/override "Code scanning results / CodeQL" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
liamfallon commented 1 month ago

/lgtm /approve

nephio-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nephio-project/nephio/blob/main/OWNERS)~~ [liamfallon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment