Evaluate and address code review feedback post R3 related to deploying Nephio management components on pre-installed k8s cluster - Githubissues

nephio-project / nephio

Nephio is a Kubernetes-based automation platform for deploying and managing highly distributed, interconnected workloads such as 5G Network Functions, and the underlying infrastructure on which those workloads depend.

Apache License 2.0

93 stars 52 forks source link

Evaluate and address code review feedback post R3 related to deploying Nephio management components on pre-installed k8s cluster #777

Open vjayaramrh opened 4 days ago

vjayaramrh commented 4 days ago

Review the below code review comments from the PR (https://github.com/nephio-project/test-infra/pull/269)

evaluate using kind.enabled approach (https://github.com/nephio-project/test-infra/pull/269/files#r1651814068)
ensure extra variables passed to playbook by user is not lost (https://github.com/nephio-project/test-infra/pull/269/files#r1647776134)
rename the tag nonkind_k8s to another meaningful such as pre_deployed_k8s, or such. (https://github.com/nephio-project/test-infra/pull/269#discussion_r1647878437)

cc: @electrocucaracha @liamfallon @radoslawc @arora-sagar