search

nephio-project / nephio

Nephio is a Kubernetes-based automation platform for deploying and managing highly distributed, interconnected workloads such as 5G Network Functions, and the underlying infrastructure on which those workloads depend.
Apache License 2.0
112 stars 52 forks source link

Add new "always" approval policy #806

Closed efiacor closed 2 months ago

efiacor commented 2 months ago

Update pkgrev.get to use api Reader to bypass cache Additional logging Update kyaml versions to sync with porch version

liamfallon commented 2 months ago

Looks good. I'll download it and tryto run the e2e tests locally.

efiacor commented 2 months ago

Ok, looks good. I am approving, but I do think it's not necessary to include the additional details in the event messages; the event is already attached to the package revision. I am unsure of whether there are optimizations in the event handling that may be defeated by adding additional info in the message rather than a static message. I guess it's still static, for that PackageRevision, so maybe it's ok.

Hi @johnbelamaric thanks for reviewing. Ye I just added the additional info for logging/debugging purposes. If you think it doesn't belong in the event, then maybe we should add it to a logger somewhere.

liamfallon commented 2 months ago

/approve /lgtm

nephio-prow[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/nephio-project/nephio/blob/main/OWNERS)~~ [johnbelamaric,liamfallon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment