search

nephros / wifi-qr-handler

0 stars 0 forks source link

Comments on the SailfishOS Community Meeting #2

Open nephros opened 1 year ago

nephros commented 1 year ago

Original Question:

https://forum.sailfishos.org/t/community-meeting-on-irc-13th-april-2023/15242/2?u=nephros

Answer/Discussion in the Meeting Log:

https://irclogs.sailfishos.org/meetings/sailfishos-meeting/2023/sailfishos-meeting.2023-04-13-07.00.log.html

07:05:31 And the answer: 07:05:34 #info The wifi handler looks like a nice start, but on the details this wouldn’t be necessarily how we’d like this implemented. 07:05:38 #info 1) not sure should the handling be in the settings app (not nice acumulating more and more to the d-bus api of the generic settings framework) or rather the connection dialog, 07:05:43 #info 2) the patch doesn’t enable the QR code network adding from anywhere (suppose that’s called from third party app then), 07:05:46 #info 3) the QR code shouldn’t be included in the details of network addition requests, rather the caller should consume QR code details and proceed with plain network properties.

nephros commented 1 year ago

Response:

07:05:34 #info The wifi handler looks like a nice start, but on the details this wouldn’t be necessarily how we’d like this implemented. 07:05:38 #info 1) not sure should the handling be in the settings app (not nice acumulating more and more to the d-bus api of the generic settings framework) or rather the connection dialog,

The current implementation introduces showAddNetworkDialogFromQR(code) in order to not touch the existing showAddNetworkDialog() so that doesn't break. The intention was for a "final" version to replace the latter with showAddNetworkDialog(code).
Thus there is no accumulation of calls in the dbus API (apart from the existing call changing).

07:05:43 #info 2) the patch doesn’t enable the QR code network adding from anywhere (suppose that’s called from third party app then),

The patch does not, but the repo (and RPM under Releases) install a scheme handler that allows it to be used.

Not exactly third-party, but usable from any third party app.
Note that this limits the source of the url-like string not to QR Codes, but makes it possible to also use ones stored in e.g. RFID-Tags, possibly BLE and other sources.

07:05:46 #info 3) the QR code shouldn’t be included in the details of network addition requests, rather the caller should consume QR code details and proceed with plain network properties.

In order to do that there would need to be an API (Dbus call again?) supporting this. Please point to it, I couldn't find one.

nephros commented 1 year ago

Bonus Question:

07:08:49 <Solrac[m]> Would it be acceptable to reimplement the patch to link to the native connection prompt and be automatically filled?

That is what the current one does, pre-filling the details of AddNetworkDialog.qml, and doing it in the same place and the same way as manually (UI) -supplied, or VPN-config-import-supplied network information is added.

AFAICS the "native connection prompt" also uses the parts from jolla-settings - so moving it would be fine but kinda pointless.

Unless I misunderstand something here.