The msi installer installs binaries into `C:\Windows\system32`

nepnep39 / neofetch-win

Simple, ultra-lightweight neofetch clone for Windows 10+ written in C++

MIT License

130 stars 9 forks source link

The msi installer installs binaries into `C:\Windows\system32` #31

Open CarterLi opened 2 months ago

CarterLi commented 2 months ago

It's EXTREMELY dangerous and may override system files

nepnep39 commented 2 months ago

Did not expect maintainer of fastfetch to open a ticket lol I will fix this in the next release, its something I had planned to do for a long time but put it off and to be honest it really should have never been a thing in the first place. It was a band-aid solution I used for testing and thought it wouldn't have mattered in the long run. Well now 60 000 people use this program and I have to take a bit more care of it lol

CarterLi commented 2 months ago

Someone installed neofetch by winget and said it worked well, so I decided to take a look at it myself.

I cant say that I agree some ideas of neofetch-win, eg. using console title as shell (mistakenly being called as terminal) name so that neofetch-win detected my nushell as ~> neofetch. I wont argue it because it should work for most pwsh users.

This issue is what I cant stand as a Windows user.

l5zh6 commented 2 months ago

Malwarebytes actually screamed about the .exe in the system32 directory, malicious AI something...