Test issues

[valerio-castelli]

Good afternoon, There seems to be an issue with your pom.xml configuration that prevents Jenkins from successfully identifying and building your tests. Please follow the "junit 5 maven" guide that you can find on Google to fix the pom and make sure that you are able to run your tests within IntelliJ using a maven build configuration with "test" as goal. Also, remove the AppTest.java file.

[nepp1d0]

Done, sorry for closing and reopening

[nepp1d0]

We should have fixed pom.xml dependencies, now maven runs correctly all local tests

[valerio-castelli]

I can confirm the problem has been solved.

[valerio-castelli]

New issue:

---

T E S T S

Running it.polimi.ingsw.model.DiceBagTest Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.053 sec - in it.polimi.ingsw.model.DiceBagTest Running it.polimi.ingsw.model.effect.PlaceDieEffectTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.038 sec - in it.polimi.ingsw.model.effect.PlaceDieEffectTest Running it.polimi.ingsw.model.effect.GetDieFromDicePoolEffectTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.015 sec - in it.polimi.ingsw.model.effect.GetDieFromDicePoolEffectTest Running it.polimi.ingsw.model.effect.RollDieEffectTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.006 sec - in it.polimi.ingsw.model.effect.RollDieEffectTest Running it.polimi.ingsw.model.effect.PlaceDieWithoutAdjacencyConstraintEffectTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in it.polimi.ingsw.model.effect.PlaceDieWithoutAdjacencyConstraintEffectTest Running it.polimi.ingsw.model.effect.ChooseDieValueEffectTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in it.polimi.ingsw.model.effect.ChooseDieValueEffectTest Running it.polimi.ingsw.model.effect.ChooseTwoDiceFromWindowPatterEffectTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in it.polimi.ingsw.model.effect.ChooseTwoDiceFromWindowPatterEffectTest Running it.polimi.ingsw.model.effect.ChooseDieFromRoundTrackEffectTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in it.polimi.ingsw.model.effect.ChooseDieFromRoundTrackEffectTest Running it.polimi.ingsw.model.effect.IncreaseValueEffectTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in it.polimi.ingsw.model.effect.IncreaseValueEffectTest Running it.polimi.ingsw.model.effect.ChooseIfDecreaseOrIncreaseValueEffectTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 sec - in it.polimi.ingsw.model.effect.ChooseIfDecreaseOrIncreaseValueEffectTest Running it.polimi.ingsw.model.effect.ReplaceDieOnRoundTrackEffectTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.014 sec - in it.polimi.ingsw.model.effect.ReplaceDieOnRoundTrackEffectTest Running it.polimi.ingsw.model.effect.PlaceDieInDraftPoolEffectTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in it.polimi.ingsw.model.effect.PlaceDieInDraftPoolEffectTest Running it.polimi.ingsw.model.effect.CheckIfRoundTrackHasAnyDieEffectTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in it.polimi.ingsw.model.effect.CheckIfRoundTrackHasAnyDieEffectTest Running it.polimi.ingsw.model.effect.DecreaseValueEffectTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec - in it.polimi.ingsw.model.effect.DecreaseValueEffectTest Running it.polimi.ingsw.model.effect.ChooseDieFromDraftPoolEffectTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in it.polimi.ingsw.model.effect.ChooseDieFromDraftPoolEffectTest Running it.polimi.ingsw.model.effect.AddDieToDicePoolEffectTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in it.polimi.ingsw.model.effect.AddDieToDicePoolEffectTest Running it.polimi.ingsw.model.effect.MoveDieWithoutNumberConstraintEffectTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in it.polimi.ingsw.model.effect.MoveDieWithoutNumberConstraintEffectTest Running it.polimi.ingsw.model.effect.EffectTest Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 sec - in it.polimi.ingsw.model.effect.EffectTest Running it.polimi.ingsw.model.effect.CheckIsDiePlacedEffectTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in it.polimi.ingsw.model.effect.CheckIsDiePlacedEffectTest Running it.polimi.ingsw.model.effect.CheckIfThereIsAtLeastTwoDieOnWindowPatterEffectTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.02 sec - in it.polimi.ingsw.model.effect.CheckIfThereIsAtLeastTwoDieOnWindowPatterEffectTest Running it.polimi.ingsw.model.effect.MoveDieWithSameColorAsDieFromRoundTrackEffectTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in it.polimi.ingsw.model.effect.MoveDieWithSameColorAsDieFromRoundTrackEffectTest Running it.polimi.ingsw.model.effect.MoveDieEffectTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in it.polimi.ingsw.model.effect.MoveDieEffectTest Running it.polimi.ingsw.model.effect.ChooseDieFromWindowPatternEffectTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec - in it.polimi.ingsw.model.effect.ChooseDieFromWindowPatternEffectTest Running it.polimi.ingsw.model.effect.CheckIfDieHasBeenPlacedEffectTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in it.polimi.ingsw.model.effect.CheckIfDieHasBeenPlacedEffectTest Running it.polimi.ingsw.model.effect.ChooseIfPlaceDieOrPlaceDieInDraftPoolEffectTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in it.polimi.ingsw.model.effect.ChooseIfPlaceDieOrPlaceDieInDraftPoolEffectTest Running it.polimi.ingsw.model.effect.CheckIsSecondTurnEffectTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.001 sec - in it.polimi.ingsw.model.effect.CheckIsSecondTurnEffectTest Running it.polimi.ingsw.model.effect.ChooseToMoveOneOrTwoDiceEffectTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 sec - in it.polimi.ingsw.model.effect.ChooseToMoveOneOrTwoDiceEffectTest Running it.polimi.ingsw.model.effect.MoveDieWithoutColorConstraintEffectTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.018 sec - in it.polimi.ingsw.model.effect.MoveDieWithoutColorConstraintEffectTest Running it.polimi.ingsw.model.effect.RollAllDiceEffectTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in it.polimi.ingsw.model.effect.RollAllDiceEffectTest Running it.polimi.ingsw.model.effect.FlipDieEffectTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in it.polimi.ingsw.model.effect.FlipDieEffectTest Running it.polimi.ingsw.model.effect.CheckIsFirstTurnEffectTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in it.polimi.ingsw.model.effect.CheckIsFirstTurnEffectTest Running it.polimi.ingsw.model.effect.ChangeTurnOrderEffectTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 sec - in it.polimi.ingsw.model.effect.ChangeTurnOrderEffectTest Running it.polimi.ingsw.model.PublicObjectiveCardTest java.lang.ArrayIndexOutOfBoundsException: -1 (grid[1][-1]) java.lang.ArrayIndexOutOfBoundsException: 5 (grid[1][5]) java.lang.ArrayIndexOutOfBoundsException: -1 (grid[2][-1]) java.lang.ArrayIndexOutOfBoundsException: 5 (grid[2][5]) java.lang.ArrayIndexOutOfBoundsException: -1 (grid[3][-1]) java.lang.ArrayIndexOutOfBoundsException: 5 (grid[3][5]) Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.18 sec - in it.polimi.ingsw.model.PublicObjectiveCardTest Running it.polimi.ingsw.model.CardsDeckTest Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.019 sec - in it.polimi.ingsw.model.CardsDeckTest Running it.polimi.ingsw.model.PlayerTest Tests run: 15, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.017 sec - in it.polimi.ingsw.model.PlayerTest Running it.polimi.ingsw.model.ToolCardTest Checking out of grid bounds because is on the edge Checking out of grid bounds because is on the edge Checking out of grid bounds because is on the edge Checking out of grid bounds because is on the edge Checking out of grid bounds because is on the edge Checking out of grid bounds because is on the edge Tests run: 34, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.069 sec - in it.polimi.ingsw.model.ToolCardTest Running it.polimi.ingsw.model.DieTest Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.234 sec - in it.polimi.ingsw.model.DieTest Running it.polimi.ingsw.model.BlankConstraintTest Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.011 sec - in it.polimi.ingsw.model.BlankConstraintTest Running it.polimi.ingsw.model.ObjCardTest java.lang.ArrayIndexOutOfBoundsException: -1 (grid[1][-1]) java.lang.ArrayIndexOutOfBoundsException: 5 (grid[1][5]) java.lang.ArrayIndexOutOfBoundsException: -1 (grid[2][-1]) java.lang.ArrayIndexOutOfBoundsException: 5 (grid[2][5]) java.lang.ArrayIndexOutOfBoundsException: -1 (grid[3][-1]) java.lang.ArrayIndexOutOfBoundsException: 5 (grid[3][5]) java.lang.ArrayIndexOutOfBoundsException: -1 (grid[1][-1]) java.lang.ArrayIndexOutOfBoundsException: 5 (grid[1][5]) java.lang.ArrayIndexOutOfBoundsException: -1 (grid[2][-1]) java.lang.ArrayIndexOutOfBoundsException: -1 (grid[3][-1]) java.lang.ArrayIndexOutOfBoundsException: 5 (grid[3][5]) Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.008 sec - in it.polimi.ingsw.model.ObjCardTest Running it.polimi.ingsw.model.CellTest Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.012 sec - in it.polimi.ingsw.model.CellTest Running it.polimi.ingsw.model.PrivateObjectiveCardTest Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.003 sec - in it.polimi.ingsw.model.PrivateObjectiveCardTest Running it.polimi.ingsw.model.PatternCardTest Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 sec - in it.polimi.ingsw.model.PatternCardTest Running it.polimi.ingsw.model.RoundTrackTest Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.008 sec - in it.polimi.ingsw.model.RoundTrackTest Running it.polimi.ingsw.model.BoardTest Tests run: 12, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.027 sec <<< FAILURE! - in it.polimi.ingsw.model.BoardTest testGetToolCards Time elapsed: 0.013 sec <<< ERROR! java.lang.NullPointerException at it.polimi.ingsw.model.BoardTest.testGetToolCards(BoardTest.java:81)

testSetToolCards Time elapsed: 0 sec <<< ERROR! java.lang.NullPointerException at it.polimi.ingsw.model.BoardTest.testSetToolCards(BoardTest.java:103)

Running it.polimi.ingsw.model.RoundTest Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.013 sec - in it.polimi.ingsw.model.RoundTest Running it.polimi.ingsw.model.AdjacencyConstraintTest Checking out of grid bounds because is on the edge Checking out of grid bounds because is on the edge Checking out of grid bounds because is on the edge Checking out of grid bounds because is on the edge Checking out of grid bounds because is on the edge Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in it.polimi.ingsw.model.AdjacencyConstraintTest Running it.polimi.ingsw.model.PlayerWindowTest Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.022 sec - in it.polimi.ingsw.model.PlayerWindowTest Running it.polimi.ingsw.model.TurnTest Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.006 sec - in it.polimi.ingsw.model.TurnTest Running it.polimi.ingsw.model.ColorConstraintTest Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 sec - in it.polimi.ingsw.model.ColorConstraintTest Running it.polimi.ingsw.model.WindowPatternTest Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.002 sec - in it.polimi.ingsw.model.WindowPatternTest Running it.polimi.ingsw.model.NumberConstraintTest Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in it.polimi.ingsw.model.NumberConstraintTest Running it.polimi.ingsw.model.MoveValidatorTest Checking out of grid bounds because is on the edge Checking out of grid bounds because is on the edge Checking out of grid bounds because is on the edge Checking out of grid bounds because is on the edge Checking out of grid bounds because is on the edge Checking out of grid bounds because is on the edge Checking out of grid bounds because is on the edge Checking out of grid bounds because is on the edge Checking out of grid bounds because is on the edge Checking out of grid bounds because is on the edge Checking out of grid bounds because is on the edge Checking out of grid bounds because is on the edge Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.007 sec - in it.polimi.ingsw.model.MoveValidatorTest Running it.polimi.ingsw.network.RMIClientTest Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.012 sec - in it.polimi.ingsw.network.RMIClientTest Running it.polimi.ingsw.network.RMIServerTest Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 sec - in it.polimi.ingsw.network.RMIServerTest Running it.polimi.ingsw.serialization.PatternConstraintAdapterTest Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.004 sec - in it.polimi.ingsw.serialization.PatternConstraintAdapterTest

Results :

Tests in error: BoardTest.testGetToolCards:81 » NullPointer BoardTest.testSetToolCards:103 » NullPointer

Tests run: 186, Failures: 0, Errors: 2, Skipped: 0

[ERROR] There are test failures.

Please fix it ASAP, you have about 12h to the deadline!

[8549]

Fixed, we forgot to removed a couple of unused lines in the test.