Closed kshitij12345 closed 1 year ago
Nice of you to open a PR :pray:
When you're ready and want to get it reviewed, post a comment in this Pull Request with this message: /quack review
@SiddhantSadangi can you have a code review on the current code. (Failures are via integration and will reach out to relevant folks)
Thanks!
/quack review
Gentle Ping @SiddhantSadangi
It's on my backlog... will get to it later today/early tomorrow
So the idea with this example is to just log some stuff to MLflow and then export that to Neptune?
yup. the only utility i see for this currently is to have the integration tested regularly through the examples test framework. But once we release the mlflow sync integration, that would add more value here.
Till then, can we add the exporter to the migration tools section of the docs?
@SiddhantSadangi have updated the run (and tagged showcase run), if everything looks good, will make a 1.0 release
PTAL, Thanks!
LGTM! ๐
Will approve and merge after unpinning the requirements post-release.
Thanks!
So the idea with this example is to just log some stuff to MLflow and then export that to Neptune?
yup. the only utility i see for this currently is to have the integration tested regularly through the examples test framework. But once we release the mlflow sync integration, that would add more value here.
Till then, can we add the exporter to the migration tools section of the docs?
Are you suggesting we should already encourage people to install the pre-release version in order to use the exporter? I'd like to get some more input from others if that's the case. My impression is we agreed to wait until everything is ready and then release the complete integration with both the exporter and plugin.
Are you suggesting we should already encourage people to install the pre-release version in order to use the exporter?
Nope. What I meant was, since the initial release (v1.0) would only have the exporter and not the sync ability (that lets to log to both MLflow and Neptune in parallel), it would make more sense to have this in the "Migration Tools" sub-category
Are you suggesting we should already encourage people to install the pre-release version in order to use the exporter?
Nope. What I meant was, since the initial release (v1.0) would only have the exporter and not the sync ability (that lets to log to both MLflow and Neptune in parallel), it would make more sense to have this in the "Migration Tools" sub-category
I understand, I just wasn't aware the scope of the 1.0 release had changed.
FYI, 1.0 is released
Description
Include a summary of the changes and the related issue.
Related to: <ClickUp/JIRA task name>
Any expected test failures? macOS Python 3.7 (latest mlflow version is not available)
Add a
[X]
to relevant checklist itemsโ This change
โ๏ธ Pre-merge checklist
๐งช Test Configuration