neptune-ai / examples

📝 Examples of how to use Neptune for different use cases and with various MLOps tools

https://neptune.ai

MIT License

77 stars 29 forks source link

Mlflow example #250

Closed kshitij12345 closed 1 year ago

kshitij12345 commented 1 year ago

Description

Include a summary of the changes and the related issue.

Related to: <ClickUp/JIRA task name>

Any expected test failures? macOS Python 3.7 (latest mlflow version is not available)

Add a [X] to relevant checklist items

❔ This change

[x] adds a new feature
[ ] fixes breaking code
[ ] is cosmetic (refactoring/reformatting)

✔️ Pre-merge checklist

[x] Refactored code (sourcery)
[x] Tested code locally
[x] Precommit installed and run before pushing changes
[x] Added code to GitHub tests (notebooks, scripts)
[ ] Updated GitHub README
[ ] Updated the projects overview page on Notion

🧪 Test Configuration

OS: Ubuntu
Python version: 3.10
Neptune version: 1.3.1
Affected libraries with version: tensorflow 2.12, mlflow 2.4.1

ghost commented 1 year ago

Nice of you to open a PR :pray: When you're ready and want to get it reviewed, post a comment in this Pull Request with this message: /quack review

kshitij12345 commented 1 year ago

@SiddhantSadangi can you have a code review on the current code. (Failures are via integration and will reach out to relevant folks)

Thanks!

kshitij12345 commented 1 year ago

/quack review

kshitij12345 commented 1 year ago

Gentle Ping @SiddhantSadangi

SiddhantSadangi commented 1 year ago

It's on my backlog... will get to it later today/early tomorrow

SiddhantSadangi commented 1 year ago

So the idea with this example is to just log some stuff to MLflow and then export that to Neptune?

yup. the only utility i see for this currently is to have the integration tested regularly through the examples test framework. But once we release the mlflow sync integration, that would add more value here.

Till then, can we add the exporter to the migration tools section of the docs?

kshitij12345 commented 1 year ago

@SiddhantSadangi have updated the run (and tagged showcase run), if everything looks good, will make a 1.0 release

PTAL, Thanks!

SiddhantSadangi commented 1 year ago

LGTM! 🎉

Will approve and merge after unpinning the requirements post-release.

Thanks!

normandy7 commented 1 year ago

So the idea with this example is to just log some stuff to MLflow and then export that to Neptune?

yup. the only utility i see for this currently is to have the integration tested regularly through the examples test framework. But once we release the mlflow sync integration, that would add more value here.

Till then, can we add the exporter to the migration tools section of the docs?

Are you suggesting we should already encourage people to install the pre-release version in order to use the exporter? I'd like to get some more input from others if that's the case. My impression is we agreed to wait until everything is ready and then release the complete integration with both the exporter and plugin.

SiddhantSadangi commented 1 year ago

Are you suggesting we should already encourage people to install the pre-release version in order to use the exporter?

Nope. What I meant was, since the initial release (v1.0) would only have the exporter and not the sync ability (that lets to log to both MLflow and Neptune in parallel), it would make more sense to have this in the "Migration Tools" sub-category

normandy7 commented 1 year ago

Are you suggesting we should already encourage people to install the pre-release version in order to use the exporter?

Nope. What I meant was, since the initial release (v1.0) would only have the exporter and not the sync ability (that lets to log to both MLflow and Neptune in parallel), it would make more sense to have this in the "Migration Tools" sub-category

I understand, I just wasn't aware the scope of the 1.0 release had changed.

kshitij12345 commented 1 year ago

FYI, 1.0 is released