search

neptune-ai / neptune-client

📘 The experiment tracker for foundation model training
https://neptune.ai
Apache License 2.0
580 stars 63 forks source link

aggregating batching based on operation step #1833

Closed szysad closed 3 months ago

szysad commented 4 months ago

Before submitting checklist

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 90.09901% with 10 lines in your changes missing coverage. Please review.

Project coverage is 78.66%. Comparing base (e0fc515) to head (58bde7e). Report is 1 commits behind head on master.

Files Patch % Lines
...ne/core/components/queue/aggregating_disk_queue.py 91.95% 7 Missing :warning:
src/neptune/core/operations/utils.py 50.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1833 +/- ## ========================================== - Coverage 80.49% 78.66% -1.84% ========================================== Files 359 219 -140 Lines 19636 9532 -10104 ========================================== - Hits 15806 7498 -8308 + Misses 3830 2034 -1796 ``` | [Flag](https://app.codecov.io/gh/neptune-ai/neptune-client/pull/1833/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=neptune-ai) | Coverage Δ | | |---|---|---| | [e2e](https://app.codecov.io/gh/neptune-ai/neptune-client/pull/1833/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=neptune-ai) | `?` | | | [e2e-management](https://app.codecov.io/gh/neptune-ai/neptune-client/pull/1833/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=neptune-ai) | `?` | | | [e2e-s3](https://app.codecov.io/gh/neptune-ai/neptune-client/pull/1833/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=neptune-ai) | `?` | | | [e2e-s3-gcs](https://app.codecov.io/gh/neptune-ai/neptune-client/pull/1833/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=neptune-ai) | `?` | | | [e2e-standard](https://app.codecov.io/gh/neptune-ai/neptune-client/pull/1833/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=neptune-ai) | `?` | | | [macos](https://app.codecov.io/gh/neptune-ai/neptune-client/pull/1833/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=neptune-ai) | `76.96% <90.09%> (-3.29%)` | :arrow_down: | | [py3.10](https://app.codecov.io/gh/neptune-ai/neptune-client/pull/1833/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=neptune-ai) | `?` | | | [py3.11](https://app.codecov.io/gh/neptune-ai/neptune-client/pull/1833/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=neptune-ai) | `?` | | | [py3.12](https://app.codecov.io/gh/neptune-ai/neptune-client/pull/1833/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=neptune-ai) | `?` | | | [py3.7](https://app.codecov.io/gh/neptune-ai/neptune-client/pull/1833/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=neptune-ai) | `?` | | | [py3.8](https://app.codecov.io/gh/neptune-ai/neptune-client/pull/1833/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=neptune-ai) | `77.09% <90.09%> (-3.29%)` | :arrow_down: | | [py3.9](https://app.codecov.io/gh/neptune-ai/neptune-client/pull/1833/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=neptune-ai) | `?` | | | [ubuntu](https://app.codecov.io/gh/neptune-ai/neptune-client/pull/1833/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=neptune-ai) | `76.96% <90.09%> (-3.28%)` | :arrow_down: | | [unit](https://app.codecov.io/gh/neptune-ai/neptune-client/pull/1833/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=neptune-ai) | `77.09% <90.09%> (+0.50%)` | :arrow_up: | | [windows](https://app.codecov.io/gh/neptune-ai/neptune-client/pull/1833/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=neptune-ai) | `77.08% <90.09%> (-3.08%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=neptune-ai#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.