search

neptune-ai / neptune-client

📘 The experiment tracker for foundation model training
https://neptune.ai
Apache License 2.0
580 stars 63 forks source link

Add py.typed file recommended by PEP 561 (v1.x) #1852

Closed antoinebrl closed 1 month ago

antoinebrl commented 3 months ago

Follow recommendations from PEP 561 – Distributing and Packaging Type Information

SiddhantSadangi commented 3 months ago

Hey @antoinebrl 👋 Thanks for this PR, and I'm sorry for the delay in getting back to you (we were at ICML last week).

Could you please point this PR to neptune-ai:dev/1.x?

antoinebrl commented 3 months ago

@SiddhantSadangi, I rebased and changed the destination. I also opened a similar PR targeting dev/v2.0 https://github.com/neptune-ai/neptune-client/pull/1855

SiddhantSadangi commented 3 months ago

Hey @antoinebrl, After further internal discussions, considering the focus on the 2.x client, we've decided not to invest effort into improving type-hinting in 1.x. I am closing this PR as not planned, but keeping #1855 open.

antoinebrl commented 3 months ago

Does this mean there will be no more releases in v1? If that isn't true or certain, I would still be in favor or adding this empty file to be compliant with PEP 561.

antoinebrl commented 2 months ago

Hello! As I suspected, there was another release in the v1 series. Unfortunately, by closing the PR, the package is still considered untyped.

SiddhantSadangi commented 2 months ago

Hey @antoinebrl , we might have a bugfix release in the v1 series soon. Will include this ✅

PatrykGala commented 1 month ago

Hello @antoinebrl Thank you for your merge request. Upon review, we've identified some issues with the type annotations in our neptune-client:

We have tested this commit and decided to merge it. However, we would like to gather feedback from you after the release.

Our goal is to bring full mypy support in neptune-client version 2.0.