search

neptune-networks / feedback

A public repository to track interest in features for Neptune Networks
5 stars 0 forks source link

Hamburger collapse no longer works #1

Closed bswinnerton closed 4 years ago

bswinnerton commented 4 years ago

For some reason a few days ago the hamburger button on mobile no longer extends to show the rest of the nav items. The following appears in the Javascript console:

bootstrap.js:1498 Uncaught TypeError: Cannot convert object to primitive value
    at RegExp.test (<anonymous>)
    at HTMLDivElement.<anonymous> (bootstrap.js:1498)
    at Function.each (jquery.js:325)
    at jQuery.fn.init.each (jquery.js:165)
    at jQuery.fn.init._jQueryInterface [as collapse] (bootstrap.js:1492)
    at HTMLDivElement.<anonymous> (bootstrap.js:1552)
    at Function.each (jquery.js:325)
    at jQuery.fn.init.each (jquery.js:165)
    at HTMLButtonElement.<anonymous> (bootstrap.js:1547)
    at HTMLDocument.dispatch (jquery.js:4670)
bswinnerton commented 4 years ago

This should now be fixed ✅.

bswinnerton commented 4 years ago

This came back up again due to a bug in jQuery

bswinnerton commented 4 years ago

This is solved for the moment, but might need to be readdressed later.

/cc https://github.com/twbs/bootstrap/issues/30553.