search

nerc-project / coldfront-plugin-cloud

ColdFront plugin to manage resource allocations on OpenStack and OpenShift
GNU General Public License v3.0
4 stars 10 forks source link

Integrate ESI into Coldfront #146

Open QuanMPhm opened 8 months ago

QuanMPhm commented 8 months ago

Closes #135 To integrate ESI and make use of the existing code, I have made a few small restructuring choices. There’s too many to list, so I will be ready for everyone’s questions on my code changes.

The ESI allocator object, implemented in esi.py, subclasses from the Openstack allocator, with a few functions overridden. The ESI allocator only makes quotas for floating IPs and networks. The appropriate Allocation Attributes have been added to attributes.py

The functional test for the ESI integration uses the same Openstack cluster put up by test-py38-functional-devstack.yaml. ci/run_functional_tests_openstack.sh has been edited to also create an ESI coldfront resource and to run the ESI functional tests.

QuanMPhm commented 8 months ago

@tzumainn Do you have an answer for the other questions I mentioned in my PR comments? I feel like there is a lot more information I need to know before being able to remotely continue solving this issue.

tzumainn commented 8 months ago

@tzumainn Do you have an answer for the other questions I mentioned in my PR comments? I feel like there is a lot more information I need to know before being able to remotely continue solving this issue.

Whoops, sorry, I missed that there were question in the files themselves; in the future it may be easier to add questions as git comments on the PR and tag the relevant people.

Anyway, floating IPs and networks are the only items I can think of that might require allocations, since I think we explicitly do not want ColdFront to limit capacity for leasing nodes.

tzumainn commented 8 months ago

I've answered the ESI specific questions; however, I'm not all that familiar with ColdFront itself, so this questions regarding allocations and the like may be better suited for Kristi.

QuanMPhm commented 4 months ago

@knikolla I have finished the integration code for now. For some unrelated reason the microshift test case is not working. I will update the README once we finish code review.

joachimweyl commented 3 months ago

@tzumainn once @knikolla approves the ColdFront side are you ready to approve the ESI side?

tzumainn commented 2 months ago

@joachimweyl sure - given that ESI is just OpenStack, and I don't have much expertise with ColdFront, I would assume everything just kind of works.

joachimweyl commented 2 months ago

@knikolla do you approve the ColdFront side?

joachimweyl commented 1 week ago

@naved001 is this resolved?