search

nerc-project / coldfront-plugin-cloud

ColdFront plugin to manage resource allocations on OpenStack and OpenShift
GNU General Public License v3.0
4 stars 10 forks source link

Avoid interactive prompts during unit tests #178

Closed larsks closed 3 weeks ago

larsks commented 3 weeks ago

Always call initial_setup with -f option to avoid the "Do you want to proceed?" interactive prompt.

larsks commented 3 weeks ago

This is failing with:

django.core.management.base.CommandError: Error: unrecognized arguments: -f

How is it failing in GitHub but not locally? I guess I will need to investigate.

larsks commented 3 weeks ago

It was failing because despite the fact that we were requiring coldfront>=1.0.4, we were only getting coldfront 1.0.4. I've added a commit that increases the minimum version to 1.1.0 (which is still compatible with >=1.0.4, so hopefully that's okay).

knikolla commented 3 weeks ago

1.1.0 is okay (in production we're at 1.1.5)

You did end up linting an entire file with your patch though.

larsks commented 3 weeks ago

You did end up linting an entire file with your patch though.

Whoops, my bad. Let's fix that.