UIVK carries full viewing key for transparent

nerdcash / Nerdbank.Cryptocurrencies

.NET libraries for processing Zcash and other cryptocurrencies.

MIT License

5 stars 3 forks source link

UIVK carries full viewing key for transparent #264

Closed AArnott closed 6 months ago

AArnott commented 7 months ago

https://github.com/nerdcash/Nerdbank.Cryptocurrencies/blob/5b968e07dff6cfbb42acb5b464d5942e449218fd/src/Nerdbank.Zcash/Transparent/PublicKey.cs#L69

Per ZIP-316, a UFVK to UIVK conversion should not contain the full public key for transparent accounts. It should instead contain the external scope derivation. But based on the code show above, I'd say this is missing.

AArnott commented 7 months ago

A related conversation, where I introduced a similar bug, is here: https://github.com/zcash/librustzcash/pull/1175#pullrequestreview-1925472291

AArnott commented 6 months ago

This doesn't actually repro as I thought it would. Not an issue. The code I found was not relevant to UFVK conversions.