nerdcash / Nerdbank.Cryptocurrencies

.NET libraries for processing Zcash and other cryptocurrencies.
MIT License
5 stars 3 forks source link

Rollback recent librustzcash upgrade #348

Closed AArnott closed 3 months ago

AArnott commented 3 months ago

This rolls back most of #342 and some of #345 due to zcash/librustzcash#1431 which breaks sync.

When that librustzcash bug is fixed, we should re-apply all of what is reverted here, and then merge in the fix from librustzcash.

As part of validation for that bug, we should run these commands, which reproduce the panic today:

D:\source\repos\Nerdbank.Cryptocurrencies\bin\Nerdbank.Zcash.Cli\x64\Release\net8.0-windows\Nerdbank.Zcash.Cli.exe new --seedPhrase "retreat..." --wallet c:\temp\regressiontest.mainnet.dat --birthday-height 2224314 --lightserverUrl https://zcash.mysideoftheweb.com:9067/
D:\source\repos\Nerdbank.Cryptocurrencies\bin\Nerdbank.Zcash.Cli\x64\Release\net8.0-windows\Nerdbank.Zcash.Cli.exe sync C:\temp\regressiontest.mainnet.dat --lightserverUrl https://zcash.mysideoftheweb.com:9067/