I noticed that when using the FileController, it would not handle missing assets. Our Sentry instance receives a lot of ActiveStorage::FileNotFoundErrors for assets that are removed from our S3 bucket.
It also blows up with ActiveRecord::RecordNotFound when requesting an invalid ID.
My suggestion is to catch these two cases and return a 404 instead.
Hello!
Love the project, really helpful!
I noticed that when using the
FileController
, it would not handle missing assets. Our Sentry instance receives a lot ofActiveStorage::FileNotFoundError
s for assets that are removed from our S3 bucket.It also blows up with
ActiveRecord::RecordNotFound
when requesting an invalid ID.My suggestion is to catch these two cases and return a 404 instead.
Thank you for the consideration!