Specify Time.rfc3339DateFormatter when decoding User

nerdishbynature / octokit.swift

A Swift API Client for GitHub and GitHub Enterprise

MIT License

501 stars 128 forks source link

Specify Time.rfc3339DateFormatter when decoding User #119

Closed dato closed 3 years ago

dato commented 3 years ago

'created_at' and 'updated_at' are included in User, but were not being properly decoded:

typeMismatch(Swift.Double, Swift.DecodingError.Context(..."created_at"...), debugDescription: "Expected to decode Double but found a string/data instead." ...))

pietbrauer commented 3 years ago

Thanks a lot for this PR!

I cherry-picked your commit in #121 as it was highlighting that our tests weren't working properly for quite some time.