search

nerdishbynature / octokit.swift

A Swift API Client for GitHub and GitHub Enterprise
MIT License
488 stars 126 forks source link

Add `perPage` argument to list releases, delete release, delete reference endpoints #137

Closed AvdLee closed 2 years ago

AvdLee commented 2 years ago

I did not add tests for the deletion endpoints since they require decoding and would not leave much of a valuable unit test looking at the other written unit tests. The test for the releases per page argument has been updated accordingly.

pietbrauer commented 2 years ago

I try to have a look today but the linting fails, please make sure you run swift format.

AvdLee commented 2 years ago

@pietbrauer missed that! Just applied SwiftFormat, so it should look good now 💪

pietbrauer commented 2 years ago

Linting still fails 🙃

AvdLee commented 2 years ago

Linting still fails 🙃

@pietbrauer is there any other script that I need to run other than SwiftFormat? There's nothing more to lint there:

avanderlee@Antoines-MBP octokit.swift % swiftformat .
Running SwiftFormat...
Reading config file at /Users/avanderlee/Developer/GIT-Projects/Forks/octokit.swift/.swiftformat
SwiftFormat completed in 0.7s.
0/45 files formatted, 2 files skipped.
pietbrauer commented 2 years ago

We always install the latest version on CI. Maybe you are running an old version? Happened to me before…

AvdLee commented 2 years ago

We always install the latest version on CI. Maybe you are running an old version? Happened to me before…

That indeed turned out to be the case, I didn't think about that! Thanks for the suggestion 💪 CI is running 🚀