search

nerdishbynature / octokit.swift

A Swift API Client for GitHub and GitHub Enterprise
MIT License
495 stars 126 forks source link

Support for Issues #34

Closed thomaspaulmann closed 8 years ago

thomaspaulmann commented 8 years ago

This PR will close Issue #33. Pull Requests are a part of the Issues. I will add them in a separated PR.

pietbrauer commented 8 years ago

👍 Looks legit, waiting for Travis.

nwest commented 8 years ago

We might need to distinguish that this is for https://github.com/issues and not https://github.com/nerdishbynature/octokit.swift/issues, for e.g.

pietbrauer commented 8 years ago

@nwest Ha, good catch!

pietbrauer commented 8 years ago

@thomaspaulmann Could you maybe change it to be like repositories and could you perhaps add some documentation for the README?

thomaspaulmann commented 8 years ago

@nwest good one, I will change it and I've already added some documentation in the README

thomaspaulmann commented 8 years ago

@nwest Does that fit your expectations?

nwest commented 8 years ago

Ah, I wasn't very clear. See here: https://developer.github.com/v3/issues/#list-issues This PR implements GET /user/issues. There's also GET /orgs/:org/issues, GET /issues, and GET /repos/:owner/:repo/issues. You don't have to implement the other methods in this PR, we'll just have to differentiate them.

Maybe add something like "Get issues across owned and member repositories for the authenticated user" to the README?

thomaspaulmann commented 8 years ago

Ok, I've decided to switch to the request GET /issues because it fits best to my use case and will add the missing documentation. Furthermore I can add the other methods/routes as well, but It could be a confusing naming.

nwest commented 8 years ago

Thanks @thomaspaulmann!

pietbrauer commented 8 years ago

Ha, there was no change to the project file?

nwest commented 8 years ago

@pietbrauer oops, I'll patch it.