search

nerdishbynature / octokit.swift

A Swift API Client for GitHub and GitHub Enterprise
MIT License
495 stars 126 forks source link

Support for Pull requests #35

Closed thomaspaulmann closed 8 years ago

thomaspaulmann commented 8 years ago

As promised, here is the second PR for the support of Pull Requests. PRs and Issues are mostly the same in GitHub, so it's a little bit ugly to separate them. Anyways, I've added some methods to separate the access to PRs or Issues. It's more or less only a filter for the optional PR-JSON-Node. Please have a look and let me know what do you think about it. An other solution is only to attach the optional Pull Request member to the Issue-Model and the programmer could decide how and what he want.

thomaspaulmann commented 8 years ago

Furthermore I improved the previous PR #34 a little bit and make the author of the issue not optional, the assignee really optional and added the HTML url to the issue itself. Have fun :smile_cat:

nwest commented 8 years ago

@thomaspaulmann could you rebase this and add the files to the project for all of the targets?

pietbrauer commented 8 years ago

This also conflicts with master now due to #36