search

nerdishbynature / octokit.swift

A Swift API Client for GitHub and GitHub Enterprise
MIT License
501 stars 128 forks source link

Add pagination to myFollowers #43

Closed andrewschreiber closed 7 years ago

andrewschreiber commented 8 years ago

Follows style of myIssues in Issues.swift

andrewschreiber commented 8 years ago

Noticed tests are failing, specifically with this error:

Test Case '-[OctoKitTests.FollowTests testGetMyFollowers]' started. 2016-05-10 02:19:22.967 xctest[66737:1793820] *** Terminating app due to uncaught exception 'NocillaUnexpectedRequest', reason: 'An unexpected HTTP request was fired.

I'm not familiar with Nocilla, so it's not clear to me what's causing the problem here.

pietbrauer commented 8 years ago

You make a HTTP request that is not stubbed, probably because there is a new parameter in the call. It should also fail locally in Xcode.

andrewschreiber commented 8 years ago

Thanks, that makes sense. Will take another look in the light of day.

pietbrauer commented 8 years ago

Ping 📲

pietbrauer commented 7 years ago

Timed out, please reopen if you feel like continuing.