Swift 2.2 compatibility

nerdishbynature / octokit.swift

A Swift API Client for GitHub and GitHub Enterprise

MIT License

490 stars 126 forks source link

Swift 2.2 compatibility #50

Closed 1ec5 closed 7 years ago

1ec5 commented 7 years ago

Conditionally compile for both Swift 2.2 and Swift 2.3. This allows the same branch to be used as a CocoaPods dependency for an individual project in both Xcode 7.3 and Xcode 8.

/cc @pietbrauer

pietbrauer commented 7 years ago

All builds failed with /Users/travis/build/nerdishbynature/octokit.swift/OctoKit/Configuration.swift:66:47: optional chain has no effect, expression already produces 'String?'

1ec5 commented 7 years ago

Thanks, that should be fixed now. iOS and tvOS builds are still failing for reasons unrelated to these changes.

pietbrauer commented 7 years ago

Closing in favour of #52 (which still has your commit, but I can't edit this one)