search

nerdishbynature / octokit.swift

A Swift API Client for GitHub and GitHub Enterprise
MIT License
501 stars 128 forks source link

Handle undocumented optional parameters in Redirect URL #59

Closed pietbrauer closed 7 years ago

pietbrauer commented 7 years ago

Since last week (around 17/2/2017) GitHub is appending the optional and unset state parameter to the redirect URI, which is unhandled (we take the last component from the URL).

This updates the framework to produce a dictionary from the URL parameters.

codecov-io commented 7 years ago

Codecov Report

Merging #59 into master will increase coverage by 0.2%. The diff coverage is 100%.

@@            Coverage Diff            @@
##           master      #59     +/-   ##
=========================================
+ Coverage   80.58%   80.78%   +0.2%     
=========================================
  Files          11       12      +1     
  Lines         654      661      +7     
=========================================
+ Hits          527      534      +7     
  Misses        127      127
Impacted Files Coverage Δ
OctoKit/Configuration.swift 74% <100%> (-0.26%) :x:
OctoKit/URL+URLParameters.swift 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 39e039c...9f1baf5. Read the comment docs.