search

nerdishbynature / octokit.swift

A Swift API Client for GitHub and GitHub Enterprise
MIT License
501 stars 128 forks source link

Fixed issue of nil htmlURL #74

Closed stephenyao closed 5 years ago

stephenyao commented 5 years ago

The htmlURL of a pull request was always nil due to the incorrect mapping of the Codable conformance of the PullRequest object.

The JSON response always returned the attribute as html_url, but this was never mapped in the PullRequest object.

pietbrauer commented 5 years ago

Thanks a lot!