search

nerdishbynature / octokit.swift

A Swift API Client for GitHub and GitHub Enterprise
MIT License
490 stars 126 forks source link

Bump Xcode, RequestKit and Swift versions #76

Closed rubiojr closed 5 years ago

rubiojr commented 5 years ago

So it's easier to build in modern macOS.

cartage update and building with Xcode 10.2 fail in Mojave otherwise.

rubiojr commented 5 years ago

:fire: some warnings in https://github.com/nerdishbynature/octokit.swift/pull/76/commits/2ba529690b702a00a8b3b2247206188338739751 also.

Screenshot 2019-03-29 at 20 37 40

I'd happily open a new PR for that if that's preferred.

rubiojr commented 5 years ago

The reason I didn't bump Xcode compat to 10.2 is because https://github.com/nerdishbynature/RequestKit/pull/63

rubiojr commented 5 years ago

https://github.com/nerdishbynature/octokit.swift/pull/76/commits/15db6ffb47bfc1e9ee53730bdc640258e876416e also bumps recommended settings:

Screenshot 2019-03-29 at 20 45 38