search

nerdishbynature / octokit.swift

A Swift API Client for GitHub and GitHub Enterprise
MIT License
490 stars 126 forks source link

Resolved problems when posting Issues #77

Closed vincode-io closed 5 years ago

vincode-io commented 5 years ago

This pull request resolves the problem in Issue #75 where the labels URL being returned from Github isn't a valid URL by removing the labelURL property on Issue.

It also resolves a decoding issue when posting issues. We needed to pass a decoder to RequestKit with a correctly set date/time decoding strategy. To do this I had to upgrade the project to RequestKit 2.3.

This pull request also updates the minimum version of Swift to 4.0 since the latest Xcode no longer supports compiling 3.0 targets.

rubiojr commented 5 years ago

Related: https://github.com/nerdishbynature/octokit.swift/pull/76

vincode-io commented 5 years ago

I re-added the now deprecated labelsURL and changed the tabs to spaces. I also updated the project settings so that spaces are now the default.

Thanks for the feedback. Let me know if I missed anything.