search

nerdocs / pydifact

A python EDIFACT library.
MIT License
156 stars 45 forks source link

Remove old Python(3.5) compatibility #36

Closed nerdoc closed 3 years ago

nerdoc commented 3 years ago

All format strings could be changed into f-Strings - but due to @theangryangel's requirements in a project (see PR), compatibility to Python 3.5 will be maintained until this project is upgraded.

This issue can be closed after his requirement is upgraded. BTW @theangryangel - what would be nice: a git pre-commit hook that checks compatibility with Python 3.5... or a CI with a Python 3.5 environment... Just if you find time.

FelixSchwarz commented 3 years ago

How about just adding Python 3.5 to your .travis.yml? I think travis still provides Python 3.5.

nerdoc commented 3 years ago

Sure. @JocelynDelalande, anything against that? You're the one who uses CI most. If you don't mind I'll add 3.5, until @theangryangel gets rid of it?

JocelynDelalande commented 3 years ago

No prob, go ahead :)

(but thanks for asking)

nerdoc commented 3 years ago

Done with 82b6c601997da145f5d2bedc337642b95e6817d3