search

nerdsplayingpnp-tud / magicaltavern-api

API-Server for the magicaltavern-Project.
GNU Affero General Public License v3.0
4 stars 2 forks source link

API Version 1.1 needed #15

Closed bitfl0wer closed 2 years ago

bitfl0wer commented 2 years ago

api/v1_0/campaigns.py:

@campaigns_api.route("/api/v1.0/campaigns//", methods=["PUT"]) # TODO: This breaks the magicaltavern-bot. An API Version v1.1 has to be created which has @campaigns_api.route("/api/v1.0/campaigns//player/", methods=["PUT"]) instead of the current PUT function. This issue got created during the merge request, to keep the current website code running, since it relies on a different version of this put request, but it breaks the bot. This is entirely my fault, since I did not create a new API Version for this change. This needs to be done now though.

Juhi838b commented 2 years ago

Campaigns need an attribute that contains the current lifecycle of the campaign. (Sign up - phase; currently running; finished/archived)

bitfl0wer commented 2 years ago

Superceeded by #18