search

nerdstein / nerdstein-design-library

Design Library for the 2017 Nerdstein Site Redesign
6 stars 4 forks source link

Questions about Best Practices #27

Open cosmicdreams opened 7 years ago

cosmicdreams commented 7 years ago

Hey Adam:

I spun up my fork of this repo and immediately ran into tweaks I wanted to make to the documentation which led me to a number of questions:

  1. Should we exclude the html directory since it's the target of so much generation. Every time we generate new patterns, the process will make deletes, additions or modifications to that directory.
  2. Why is the root level composer.json needed?
  3. At first generation a lot of images are deleted, is that mistake?
  4. When you first run composer install in the design-library you are prompted to merge or replace for three folders, can we default to Merge and not prompt the user? Require them to provide an argument?
nerdstein commented 7 years ago

Hey chris, thanks again for checking this out. I'll respond to each point

  1. I use that for my pull request workflow. This is how I view a full representation to preview when reviewing changes. It would be great if we can find a way to limit it to just pages or specific patterns (the pages themselves). I'm not sure if that would help or not... It really should just track changes made across any pattern.

  2. This was the metadata needed for it to integrate cleanly with the Drupal site

  3. I'm not sure. I haven't started from scratch lately.

  4. That seems reasonable to me - should we update the documentation?

nerdstein commented 6 years ago

Note: I just did a fresh install on a second laptop. I made some minor adjustments. I think most of these things are resolved now.

@cosmicdreams do you want to play around with this again?

nerdstein commented 6 years ago

I could see some updates to the pull request template that asks a contributor to specify one or more of the patterns affected (or a page if there are some global changes). This is what happens with each generation of the HTML directory.

I'd like to see if there are tokens in the pull request template that somehow automate the username and branch from the code being submitted.