search

nerdunit / androidsideloader

GNU General Public License v3.0
236 stars 54 forks source link

Fix Spoofer.Init on non-english Windows #10

Closed ov3rk1ll closed 3 years ago

ov3rk1ll commented 3 years ago

On my German windows installation, the Spoofer.Init call hangs indefinitely which causes the tool to never open. This happens because the keytool command is also in German so it expects on of the commands to "ja" instead of "yes.

This MR inlines all required parameter into a single keytool call which removes the requirement for any interactive WriteLine calls.

Ideally this should be tested on a English OS as well as with other languages since I can only confirm this change on my German Windows.

nerdunit commented 3 years ago

Thank you for this pull request, merging now.