search

nerdydrew / Random-Pokemon-Generator

Source code for randompokemon.com
https://randompokemon.com
GNU General Public License v2.0
88 stars 31 forks source link

Added toggle to remove Pokemon that are unselectable in the Stadium games #7

Closed crazyp4l closed 1 year ago

crazyp4l commented 1 year ago

One of the large use cases I've seen for your app is in the Pokemon Stadium Rental Rando challenge. However, in the Stadium games there are a few Pokemon that are unselectable from the rental pool: In Stadium 1 it's Mew/Mewtwo In Stadium 2 it's Mew/Mewtwo/Celebi/Ho-Oh/Lugia

When doing the challenge and you roll one of those mons you have to scrap your entire team and roll another one, which can be a bit unfortunate.

I added an additional checkbox that will stop those mons from appearing if it's selected. I tried to follow all the existing conventions you had and keep everything on par.

If you see something you don't like or even just aren't interested in this change, no worries just let me know!

Thanks for taking a look at this.

nerdydrew commented 1 year ago

Thanks for your contribution! That's a fun use case. I made only minor changes:

  1. Hide the checkbox unless Kanto or Johto is selected as the region.
  2. I renamed pickable to stadiumRental because it's clearer to me.
crazyp4l commented 1 year ago

Makes perfect sense, naming things is hard 😅 Hiding the checkbox unless those regions are selected is a great idea - good call!

Thanks again, appreciate it!