search

nerfstudio-project / nerfacc

A General NeRF Acceleration Toolbox in PyTorch.
https://www.nerfacc.com/
Other
1.38k stars 112 forks source link

Tiny error in if statement #122

Closed nlml closed 1 year ago

nlml commented 1 year ago

https://github.com/KAIR-BAIR/nerfacc/blob/76c0f9817da4c9c8b5ccf827eb069ee2ce854b75/examples/train_ngp_nerf.py#L203

Should this not be: if (near_plane is not None) and (far_plane is not None):?

liruilong940607 commented 1 year ago

Hi this has been fixed in the master! See #97

nlml commented 1 year ago

Oops, didn't realise I wasn't on the master branch - thanks! :)